HoshinoKoji/psychojs
1
0
Fork 0
mirror of https://github.com/psychopy/psychojs.git synced 2025-05-12 08:38:10 +00:00
Code Actions Packages Releases Activity

util/PsychObject: retun false if prev value undefined, clean up comments

Browse Source
This commit is contained in:
Sotiri Bakagiannis 2020-09-07 14:10:10 +01:00
parent fec54b41e5
commit cb4b9e7f5b
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
js/util/PsychObject.js
View File

@ -324,7 +324,7 @@ export class PsychObject extends EventEmitter
{ {
// Not that any of the following lines should throw, but evaluating // Not that any of the following lines should throw, but evaluating
// `this._vertices.map` on `ShapeStim._getVertices_px()` seems to // `this._vertices.map` on `ShapeStim._getVertices_px()` seems to
return; return false;
} }
// Need check for equality differently for each type of attribute somehow, // Need check for equality differently for each type of attribute somehow,
@ -333,9 +333,12 @@ export class PsychObject extends EventEmitter
const prev = toString(previousAttributeValue); const prev = toString(previousAttributeValue);
const next = toString(attributeValue); const next = toString(attributeValue);
// Objects that belong to us such as colors feature a `toString()` // The following check comes in handy when figuring out a `hasChanged` predicate
// method, exclude others that don't, important in turn when figuring // in a `ShapeStim.setPos()` call for example. Objects that belong to us, such as
// out a `hasChanged` in a `ShapeStim.setPos()` for example // colors, feature a `toString()` method of their own. The types of input that
// `util.toString()` might try, but fail to stringify in a meaningful way are assigned
// an 'Object (circular)' string representation. For being opaque as to their raw
// value, those types of input are excluded below.
return prev !== 'Object (circular)' && next !== 'Object (circular)' && prev !== next; return prev !== 'Object (circular)' && next !== 'Object (circular)' && prev !== next;
} }