HoshinoKoji/psychojs
1
0
Fork 0
mirror of https://github.com/psychopy/psychojs.git synced 2025-05-11 16:18:10 +00:00
Code Actions Packages Releases Activity

util/PsychObject: expand on the has changed comparison when setting attributes

Browse Source
This commit is contained in:
Sotiri Bakagiannis 2020-08-19 13:30:36 +01:00
parent 640ae93a04
commit 056ea555e5
1 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
js/util/PsychObject.js
View File

@ -319,7 +319,24 @@ export class PsychObject extends EventEmitter
const previousAttributeValue = this['_' + attributeName];
this['_' + attributeName] = attributeValue;
return (attributeValue !== previousAttributeValue);
// Things seem OK without this check except for 'vertices'
if (typeof previousAttributeValue === 'undefined')
{
// Not that any of the following lines should throw, but evaluating
// `this._vertices.map` on `ShapeStim._getVertices_px()` seems to
return;
}
// Need check for equality differently for each type of attribute somehow,
// Lodash has an example of what an all encompassing solution looks like below,
// https://github.com/lodash/lodash/blob/master/.internal/baseIsEqualDeep.js
const prev = toString(previousAttributeValue);
const next = toString(attributeValue);
// Objects that belong to us such as colors feature a `toString()`
// method, exclude others that don't, important in turn when figuring
// out a `hasChanged` in a `ShapeStim.setPost()` for example
return prev !== 'Object (circular)' && next !== 'Object (circular)' && prev !== next;
}