From b6e096a1cc1a32c75fbd9a0e06fb5f060108892b Mon Sep 17 00:00:00 2001 From: bjoluc Date: Tue, 8 Nov 2022 16:49:36 +0100 Subject: [PATCH] Add missing `css_classes` unit test --- packages/jspsych/src/timeline/Trial.spec.ts | 18 ++++++++++++++++++ packages/jspsych/src/timeline/Trial.ts | 2 -- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/packages/jspsych/src/timeline/Trial.spec.ts b/packages/jspsych/src/timeline/Trial.spec.ts index a80252dd..3e31e7ef 100644 --- a/packages/jspsych/src/timeline/Trial.spec.ts +++ b/packages/jspsych/src/timeline/Trial.spec.ts @@ -144,6 +144,24 @@ describe("Trial", () => { }); }); + it("respects the `css_classes` trial parameter", async () => { + const displayElement = dependencies.getDisplayElement(); + + let trial = createTrial({ type: TestPlugin, css_classes: "class1" }); + expect(displayElement.classList.value).toEqual(""); + trial.run(); + expect(displayElement.classList.value).toEqual("class1"); + await TestPlugin.finishTrial(); + expect(displayElement.classList.value).toEqual(""); + + trial = createTrial({ type: TestPlugin, css_classes: ["class1", "class2"] }); + expect(displayElement.classList.value).toEqual(""); + trial.run(); + expect(displayElement.classList.value).toEqual("class1 class2"); + await TestPlugin.finishTrial(); + expect(displayElement.classList.value).toEqual(""); + }); + it("invokes the local `on_finish` callback with the result data", async () => { const onFinishCallback = jest.fn(); const trial = createTrial({ type: TestPlugin, on_finish: onFinishCallback }); diff --git a/packages/jspsych/src/timeline/Trial.ts b/packages/jspsych/src/timeline/Trial.ts index 05807349..ef98beff 100644 --- a/packages/jspsych/src/timeline/Trial.ts +++ b/packages/jspsych/src/timeline/Trial.ts @@ -115,8 +115,6 @@ export class Trial extends TimelineNode { ); } - // TODO there were `Trial` unit tests for css classes once => restore them! - /** * Add the CSS classes from the `css_classes` parameter to the display element */