From 51ebc5449b5453ef95fce9a469c0df7d5c1944de Mon Sep 17 00:00:00 2001 From: max-lovell Date: Tue, 6 Aug 2024 19:27:31 +0100 Subject: [PATCH] Array.from() -> Array.prototype.slice.call() in free sort and maxdiff plugins --- packages/plugin-free-sort/src/index.ts | 2 +- packages/plugin-maxdiff/src/index.ts | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/plugin-free-sort/src/index.ts b/packages/plugin-free-sort/src/index.ts index a736bba8..9deaba5d 100644 --- a/packages/plugin-free-sort/src/index.ts +++ b/packages/plugin-free-sort/src/index.ts @@ -348,7 +348,7 @@ class FreeSortPlugin implements JsPsychPlugin { let cur_in = false; // draggable items - const draggables = Array.from( + const draggables = Array.prototype.slice.call( display_element.querySelectorAll(".jspsych-free-sort-draggable") ); diff --git a/packages/plugin-maxdiff/src/index.ts b/packages/plugin-maxdiff/src/index.ts index c7b822a2..14559529 100644 --- a/packages/plugin-maxdiff/src/index.ts +++ b/packages/plugin-maxdiff/src/index.ts @@ -185,12 +185,12 @@ class MaxdiffPlugin implements JsPsychPlugin { // check response if (trial.required) { // Now check if one of both left and right have been enabled to allow submission - var left_checked = Array.from(document.getElementsByName("left")).some( - (c: HTMLInputElement) => c.checked - ); - var right_checked = Array.from(document.getElementsByName("right")).some( - (c: HTMLInputElement) => c.checked - ); + var left_checked = Array.prototype.slice + .call(document.getElementsByName("left")) + .some((c: HTMLInputElement) => c.checked); + var right_checked = Array.prototype.slice + .call(document.getElementsByName("right")) + .some((c: HTMLInputElement) => c.checked); if (left_checked && right_checked) { (document.getElementById("jspsych-maxdiff-next") as HTMLInputElement).disabled = false;